Skip to content

Fix visual regression false positives due to UUID truncation race #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Oct 10, 2026
Merged

Fix visual regression false positives due to UUID truncation race #3407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/ui/lib/Truncate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ export const Truncate = ({
const [truncated, setTruncated] = useState(false)

// Middle truncation has to be computed up front in order to render at all,
// and recomputed whenever the container resizes
// and recomputed whenever the container resizes or a web font finishes
// loading. Canvas measures with fallback font metrics until the real font
// is ready, and the swap doesn't necessarily resize the container, so the
// observer alone would leave a stale truncation based on the fallback font.
useLayoutEffect(() => {
const el = ref.current
if (position !== 'middle' || !el) return
Expand All @@ -55,7 +58,11 @@ export const Truncate = ({
update()
const observer = new ResizeObserver(update)
observer.observe(el)
return () => observer.disconnect()
document.fonts.addEventListener('loadingdone', update)
return () => {
observer.disconnect()
document.fonts.removeEventListener('loadingdone', update)
}
}, [text, position])

// For end truncation, CSS does the actual truncating and the only decision
Expand Down
Loading