Repository navigation
fix: resolve compiler warnings, calloc argument ordering, and typos - #537
Merged
Merged
Conversation
- Swap calloc parameter order (num, size) in render_submit_queue and its unit test to match standard signature and fix calloc-transposed-args warnings. - Explicitly cast expected_size to int in protocol_helper unit tests to silence signed/unsigned comparison warnings. - Fix "Coposite" typo to "Composite" in ro_composite_tile_storage_id and update matching test assertion. - Add thread delay after finish_workers() in queue test to ensure asynchronous log flushing completes before Catch2 assertions run.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 81.54% 89.70% +8.16%
==========================================
Files 24 24
Lines 5645 5468 -177
==========================================
+ Hits 4603 4905 +302
+ Misses 1042 563 -479 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Qualify default option string as const to eliminate ISO C++ -Wwrite-strings warning when compiling with Catch2 tests. - Separate heap buffer management from option string reading to ensure clear ownership and safe memory deallocation. - Rename ambiguous variables (ctx, connection_str) to improve code readability.
hummeltech
force-pushed
the
AddressWarnings
branch
from
November 1, 2026 02:28
651ce21 to
9652ed7
Compare
|
|
||
| if (memcached_options_buf != NULL) { | ||
| // Strip "memcached://" scheme (12 chars) and prefix with "--server=" | ||
| snprintf(memcached_options_buf, connection_string_len - 2, "--server=%.*s", |
| g_logger(G_LOG_LEVEL_DEBUG, "init_storage_memcached: Creating memcached ctx with options '%s'", connection_str); | ||
| ctx = memcached(connection_str, strlen(connection_str)); | ||
| g_logger(G_LOG_LEVEL_DEBUG, "init_storage_memcached: Creating memcached ctx with options '%s'", memcached_options); | ||
| memcached_st * memcached_storage_ctx = memcached(memcached_options, strlen(memcached_options)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.