Repository navigation
added five unit tests for getOsmCalevents() - #13190
Open
hemaksh2007jain-bit wants to merge 2 commits into
Open
hemaksh2007jain-bit wants to merge 2 commits into
hemaksh2007jain-bit wants to merge 2 commits into
Conversation
matkoniecz
added
the
ai-assisted
matkoniecz
reviewed
Nov 10, 2026
matkoniecz
marked this pull request as draft
November 10, 2026 18:04
Collaborator
|
@hemaksh2007jain-bit please - mark it as ready for review once you confirmed that it is ready |
hemaksh2007jain-bit
marked this pull request as ready for review
November 10, 2026 18:17
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance used for breaking down the typescript code and furnishing the draft code .
changes made :
-Added a new test file test/spec/services/osmcal.js
-Added five unit tests for getOsmCalEvents() covering cancelled event filtering, API query parameters, caching, JSON parsing failures, and network request failures.
human verification :
I reviewed the three files = modules/services/osmcal.ts ,
test/spec/services/nominatim.js ,
test/spec/services/kartaview.js
and identified the five behaviours that need test coverage .
Reviewed and verified the drafted test code against the service implementation.
Testing :
All 5 OsmCal tests passing.
Service test suite: 132 passed.
ESLint passing.
Related issue: #13128