Repository navigation
Render railway=turntable areas as dark gray (fixes #13165) - #13166
Hirdyansh-bh wants to merge 4 commits into
Conversation
it looks like PR description is also LLM generated |
|
for code change itself - it seems correct and making sense, and simpler than I expected |
|
Fair point! I used it to format and structure the description write up neatly, but from now on , I'll write it by myself. |
|
Added a dedicated 2px #444 border so the rim remains defined against dark aerial imagery even when deselected. ##BEFORE
##AFTER
|
|
though people with a better taste may request followup changes... |
|
Ah, I see that, it does look a bit heavy when zoomed out like that. I am completely down to add a low-zoom rule to give it that extra polish (maybe we drop the stroke back to 1px at lower zooms?). It will be a quick change—just give me the green light and I’ll push the update right away! 😄 |
|
oh, you do not need permission - feel free to try tweaking (though best to post updated takes how it looks once finished) |
|
sure, will revert in a few minutes |
|
reverting should not be needed- low zoom style is added with extra property https://github.com/openstreetmap/iD/pull/13042/changes was using some |
|
Makes sense! I avoided the :not() trick and just flipped the logic to match standard conventions: it now defaults to 1px for all lower zooms, and only thickens to 2px at .z18 and above. Just pushed the update. |




Summary of Changes
Fixes #13165.
Closed
railway=turntableways were rendering with the default untagged area style (translucent white fill and generic gray outline) becausetag-railway-turntablewas not defined incss/25_areas.css.This change adds
path.stroke.tag-railway-turntableandpath.fill.tag-railway-turntableto the/* Dark Gray things */section incss/25_areas.css, rendering turntable polygons consistently with other railway and paved infrastructure (liketag-landuse-railwayandtag-amenity-parking).Verification
railway=turntable#13165 (#map=22/32.7028492/-117.1537513).npm run test:once: 138 files passed, 2302 tests passed).npm run test:typecheck).Note on LLM usage: A LLM was used to understand and breakdown the issue. All the changes made to the code have been done by me and I have complete knowledge of the changes made.