Skip to content

Render railway=turntable areas as dark gray (fixes #13165) - #13166

Open
Hirdyansh-bh wants to merge 4 commits into
openstreetmap:developfrom
Hirdyansh-bh:fix-railway-turntable-13165
Open

Hirdyansh-bh wants to merge 4 commits into
openstreetmap:developfrom
Hirdyansh-bh:fix-railway-turntable-13165

Conversation

@Hirdyansh-bh

Copy link
Copy Markdown

Summary of Changes

Fixes #13165.

Closed railway=turntable ways were rendering with the default untagged area style (translucent white fill and generic gray outline) because tag-railway-turntable was not defined in css/25_areas.css.

This change adds path.stroke.tag-railway-turntable and path.fill.tag-railway-turntable to the /* Dark Gray things */ section in css/25_areas.css, rendering turntable polygons consistently with other railway and paved infrastructure (like tag-landuse-railway and tag-amenity-parking).

Verification

  • Tested locally on the turntable referenced in Map rendering for railway=turntable #13165 (#map=22/32.7028492/-117.1537513).
  • Passed test suite (npm run test:once: 138 files passed, 2302 tests passed).
  • Passed type check (npm run test:typecheck).
Note on LLM usage: A LLM was used to understand and breakdown the issue. All the changes made to the code have been done by me and I have complete knowledge of the changes made.
image

@matkoniecz

Copy link
Copy Markdown
Collaborator

Note on LLM usage: A LLM was used to understand and breakdown the issue. All the changes made to the code have been done by me and I have complete knowledge of the changes made.

it looks like PR description is also LLM generated

@matkoniecz

matkoniecz commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

for code change itself - it seems correct and making sense, and simpler than I expected

@Hirdyansh-bh

Copy link
Copy Markdown
Author

Fair point! I used it to format and structure the description write up neatly, but from now on , I'll write it by myself.
Also I am glad to hear that the code change itself looks good and makes sense!

@matkoniecz

Copy link
Copy Markdown
Collaborator

https://pr-13166--ideditor.netlify.app/#disable_features=boundaries&map=19.94/50.02770/19.98638&background=Bing

maybe it can get some sort of extra border? To be more visible?

screen-2026-11-10-19-02-13

@Hirdyansh-bh

Copy link
Copy Markdown
Author

Added a dedicated 2px #444 border so the rim remains defined against dark aerial imagery even when deselected.

##BEFORE

image

##AFTER

image

@matkoniecz

Copy link
Copy Markdown
Collaborator

though people with a better taste may request followup changes...

@matkoniecz

matkoniecz commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

hmmm, how it looks when mapper zooms out (with this feature deselected)

do we need extra low-zoom rule? seems not needed for me, but would make it a tiny bit better

screen-2026-11-10-19-42-31

left one on a white building is a test data

@Hirdyansh-bh

Copy link
Copy Markdown
Author

Ah, I see that, it does look a bit heavy when zoomed out like that. I am completely down to add a low-zoom rule to give it that extra polish (maybe we drop the stroke back to 1px at lower zooms?).

It will be a quick change—just give me the green light and I’ll push the update right away! 😄

@matkoniecz

Copy link
Copy Markdown
Collaborator

oh, you do not need permission - feel free to try tweaking (though best to post updated takes how it looks once finished)

@Hirdyansh-bh

Copy link
Copy Markdown
Author

sure, will revert in a few minutes

@matkoniecz

Copy link
Copy Markdown
Collaborator

reverting should not be needed- low zoom style is added with extra property

https://github.com/openstreetmap/iD/pull/13042/changes was using some not trick that may be not needed here - take look at other low zoom definitions

@Hirdyansh-bh

Copy link
Copy Markdown
Author

Makes sense! I avoided the :not() trick and just flipped the logic to match standard conventions: it now defaults to 1px for all lower zooms, and only thickens to 2px at .z18 and above. Just pushed the update.

This branch was successfully deployed

1 active (outdated) deployment
pr-preview-13166 — 2da3e6e4 Deployed Nov 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map rendering for railway=turntable

2 participants