Repository navigation
Preserve universal fields when changing presets - #13125
Open
Hirdyansh-bh wants to merge 6 commits into
Open
Hirdyansh-bh wants to merge 6 commits into
Hirdyansh-bh wants to merge 6 commits into
Conversation
k-yle
requested changes
Nov 5, 2026
k-yle
left a comment
k-yle
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the PR, please see suggestions below for how we could simplify this
k-yle
added
the
bug-release-blocker
Author
|
i am working on the fixes and will revert shortly |
Author
|
@k-yle Thanks for the review! I've reverted the extra filter in change_preset.ts, simplified the test logic by removing the try...catch block, and added a CHANGELOG entry. |
k-yle
approved these changes
Nov 5, 2026
k-yle
left a comment
k-yle
left a comment
Collaborator
There was a problem hiding this comment.
thanks, this LGTM now. lets wait a bit in case anyone else has opinions
Author
|
Sounds good, thanks again for the guidance! |
Author
|
any updates? |
Author
|
also it would be really helpful of you if you assign me my next issue on which i can work on |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching between presets (such as from a primary road to a link road), tags associated with universal fields like
namewere being stripped if the new preset did not explicitly list them in itsfieldsarray.presetManager.universal()in preserved fields when switching presetsoldPresetFieldKeysso they are not treated as obsolete keys to removetest/spec/actions/change_preset.jsCloses #13105