Repository navigation
Prepare the 5.0.0 release - #278
Merged
Merged
Conversation
The less polymorphic [`Input] elt was a workaround for an Eliom PPX weak-type issue. I think it is not needed anymore with Eliom 13.
Warning 22 is not suppressed anymore since the move to ocsigen-dune-rules gen-library, which also replaced the include_subdirs setup. Ot.Icons.Make is compared to 4.3.0, where ICON_HTML did not exist yet.
It lets odoc_driver resolve the references of the manual to Eliom (Eliom.Shared and the Eliom manual pages), on ocaml.org as well.
The overview did not mention Form, Icons, Page_transition, Pulltorefresh and Tip. Client-only modules now link to the client API, as their server pages are empty.
The manual links to the Ocsigen Start manual. Ocsigen Start depends on the toolkit, so odoc asks for x-extra-doc-deps instead of a regular dependency, for ocaml.org to resolve these links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes before releasing 5.0.0, right after Eliom 13.
Ot.Form.password_togglegets back its 4.3.0 type. The Eliom PPX weak-type workaround seems not needed anymore with Eliom 13 master.odoc-config.sexp, so that the references of the manual to Eliom resolve, also on ocaml.org.Ot.Lib.x-extra-doc-deps: ["ocsigen-start"], as the odoc manual recommends for a reverse dependency.I checked the manual with
odoc_driver ocsigen-toolkit --remapon an installed copy. All references resolve, except the links to the Ocsigen Start manual, which need the extra doc dependency above.One question about the last commit: until Ocsigen Start 9 is on opam, no published ocsigen-start accepts toolkit 5. I am not sure how ocaml.org handles an extra doc dependency it cannot install. Should we keep this commit, or drop it and add it back after the Start release?