Skip to content

Use new ocsigen-dune-rules gen-library command - #247

Merged
balat merged 3 commits into
ocsigen:masterfrom
Julow:ocsigen-dune-rules-released
Oct 29, 2026
Merged

balat merged 3 commits into
ocsigen:masterfrom
Julow:ocsigen-dune-rules-released

Conversation

@Julow

@Julow Julow commented May 29, 2026

Copy link
Copy Markdown
Contributor

The dune rules are now entirely generated by ocsigen-dune-rules.
The generation options can be modified at any time using the promotion rule.

The Dune rules for every Ocsigen libraries and applications are now maintained in one place https://github.com/ocsigen/ocsigen-dune-rules

This ensures that the fields are all correct and are the same everywhere. We also don't have to modify the complicated rules anymore.

This is a draft because ocsigen-dune-rules is not released yet.

@Julow
Julow force-pushed the ocsigen-dune-rules-released branch from a9049db to 9d4173a Compare June 26, 2026 16:01
@Julow
Julow force-pushed the ocsigen-dune-rules-released branch from d58cdcf to d5bd227 Compare September 18, 2026 15:44
@Julow
Julow force-pushed the ocsigen-dune-rules-released branch from d5bd227 to 07c35d7 Compare October 16, 2026 09:15
@Julow

Julow commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Updated to the latest version of ocsigen-dune-rules.

Comment thread src/widgets/dune
(action
(with-stdout-to
%{target}
(system "printf '('; ocamlfind query -i-format js_of_ocaml; printf ')'"))))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this rule because it seems completely unnecessary. What was the reason for it ?

Julow and others added 3 commits October 29, 2026 14:20
The dune rules are now entirely generated by ocsigen-dune-rules.
The generation options can be modified at any time using the promotion
rule.

The Dune rules for every Ocsigen libraries and applications are now
maintained in one place:
https://github.com/ocsigen/ocsigen-dune-rules

This ensures that the fields are all correct and are the same
everywhere. We also don't have to modify the complicated rules anymore.
The branch modernize is merged; main has the gen-library and
gen-client-modules commands used here.
@balat
balat force-pushed the ocsigen-dune-rules-released branch from 07c35d7 to 077323c Compare October 29, 2026 14:15
@balat

balat commented Oct 29, 2026

Copy link
Copy Markdown
Member

I rebased this branch on master and added a commit that pins ocsigen-dune-rules#main in the CI workflows (the pin of the branch modernize was why the CI failed: no gen-client-modules command there). dune-rules main now accepts Eliom 13.0~dev (ocsigen-dune-rules#25), so the pins should resolve.

@balat
balat merged commit e7c3a36 into ocsigen:master Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants