Repository navigation
Use new ocsigen-dune-rules gen-library command - #247
Merged
Merged
Conversation
Julow
force-pushed
the
ocsigen-dune-rules-released
branch
from
June 26, 2026 16:01
a9049db to
9d4173a
Compare
Julow
force-pushed
the
ocsigen-dune-rules-released
branch
from
September 18, 2026 15:44
d58cdcf to
d5bd227
Compare
Julow
force-pushed
the
ocsigen-dune-rules-released
branch
from
October 16, 2026 09:15
d5bd227 to
07c35d7
Compare
Contributor
Author
|
Updated to the latest version of ocsigen-dune-rules. |
Julow
commented
Oct 16, 2026
| (action | ||
| (with-stdout-to | ||
| %{target} | ||
| (system "printf '('; ocamlfind query -i-format js_of_ocaml; printf ')'")))) |
Contributor
Author
There was a problem hiding this comment.
I removed this rule because it seems completely unnecessary. What was the reason for it ?
The dune rules are now entirely generated by ocsigen-dune-rules. The generation options can be modified at any time using the promotion rule. The Dune rules for every Ocsigen libraries and applications are now maintained in one place: https://github.com/ocsigen/ocsigen-dune-rules This ensures that the fields are all correct and are the same everywhere. We also don't have to modify the complicated rules anymore.
The branch modernize is merged; main has the gen-library and gen-client-modules commands used here.
balat
force-pushed
the
ocsigen-dune-rules-released
branch
from
October 29, 2026 14:15
07c35d7 to
077323c
Compare
Member
|
I rebased this branch on master and added a commit that pins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dune rules are now entirely generated by ocsigen-dune-rules.
The generation options can be modified at any time using the promotion rule.
The Dune rules for every Ocsigen libraries and applications are now maintained in one place https://github.com/ocsigen/ocsigen-dune-rules
This ensures that the fields are all correct and are the same everywhere. We also don't have to modify the complicated rules anymore.
This is a draft because ocsigen-dune-rules is not released yet.