[LeonarddeR]

Link to issue number:

Follow-up of #20894

Summary of the issue:

#20894 changed how NVDA reads comment threads in Microsoft Word via UI Automation. It was merged without unit tests, these were diverged to a later pr.

Description of user facing changes:

None.

Description of developer facing changes:

The unit tests for NVDA objects move into a tests/unit/test_NVDAObjects package. test_NVDAObjects_UIA.py becomes test_NVDAObjects/test_UIA.py. test_NVDAObjects_IAccessible_ia2Web.py becomes test_NVDAObjects/test_IAccessible_ia2Web.py.

Description of development approach:

A new module, test_NVDAObjects/test_UIA_wordDocument.py, tests the comment support of Word via UI Automation. The UIA elements are mocks. The text ranges come from BasicTextProvider in the unit test helpers.

The tests cover:

• The presentation of a comment, a comment without a date, a resolved comment and a reply.
• The detection of resolved comments from the annotation types of the commented text.
• Finding the thread of a reply, for modern and classic comments.
• Fetching a thread with its replies. This includes the runtime ID of the thread element, and the text of a classic comment from its edit field.
• Finding the comment at a position: comment hint buttons, threads, classic comments, other annotation objects, and the resolved state.
• The comment items of the Elements List: the annotation types they match, their labels, the nesting of replies and revisions, and fetching replies only when the list moves past a comment.
• Listing a comment once in the Elements List when consecutive comment items belong to the same thread. Comment items without a thread are never skipped.
• The speech and braille output of NVDA+alt+c, and the browseable message when the command is pressed twice.
• The deprecated getCommentInfoFromPosition and getPresentableCommentInfoFromPosition.

Testing strategy:

Unit tests.

Known issues with pull request:

None.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[Copilot]

Copilot review overview

🟡 Changes recommended

The suite misses dateless reply/resolved behavior and does not fully verify deferred reply fetching.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• Preserve reply and resolved states when annotation date is missing · New
• Resume lazy-fetch iterator to verify comments and replies are fetched · New

What changed in this PR

Adds UIA Word comment-thread unit coverage and reorganizes NVDA object tests into a dedicated package.

Changes:

• Adds tests for comment presentation, resolution, navigation, and reporting.
• Moves existing UIA and IA2 web tests into test_NVDAObjects.

File	Description
tests/​unit/​test_NVDAObjects/​__init__.py	Defines the new test package.
tests/​unit/​test_NVDAObjects/​test_UIA.py	Relocates existing UIA tests.
tests/​unit/​test_NVDAObjects/​test_IAccessible_ia2Web.py	Relocates existing IA2 web tests.
tests/​unit/​test_NVDAObjects/​test_UIA_wordDocument.py	Adds Word comment-thread tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[LeonarddeR]

@seanbudd These tests are left from #20894 and belong to 2027.1 I think