Repository navigation
refactor: use useQRCode from @vueuse/integrations for all QR codes - #66150
Merged
Merged
Conversation
The QR codes for the mobile login, the app password setup and the public share links were rendered with `@chenfengyuan/vue-qrcode`, a different major version in each frontend. They now all use `useQRCode` and render the code as an image, so the component dependency is dropped from both frontends. The share link QR code is only generated once its dialog is opened. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
susnux
marked this pull request as ready for review
November 2, 2026 16:43
susnux
requested review from
kristian-zendato,
pringelmann,
skjnldsv and
szaimen
and removed request for
a team
November 2, 2026 16:43
skjnldsv
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use consistent way for generating QR codes, removing duplicated dependencies
Checklist
3. to review, feature component)stable32)AI (if applicable)