Repository navigation
Conversation
ThorMicah
force-pushed
the
mthorste/CUMULUS-5883
branch
from
November 16, 2026 15:13
5524e20 to
6d99908
Compare
Contributor
|
@ThorMicah just a heads-up in case you're wondering. I pushed a CL update resolving a merge conflict just to trigger CI and re-deploy your stack for security. |
ThorMicah
force-pushed
the
mthorste/CUMULUS-5883
branch
from
November 19, 2026 18:09
5bbadd1 to
db94963
Compare
ThorMicah
force-pushed
the
mthorste/CUMULUS-5883
branch
from
November 19, 2026 18:12
8f9a8a2 to
03b9c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-XX: Develop amazing new feature
Changes
The
Providerfield is an optional field to include in the CNM-S message. So data providers publishing messages without it will also not see it in the CNM-R response that is returned. That is due to how the CNM-R message is constructed, using the original CNM-S message fields (seen here).I verified with the team that requested this feature that their data providers are not sending CNM-S messages with the
Providerfield.This PR provides fall-back logic to retrieve the
Providerfield from the Cumulus message. It will not overwrite the field if the CNM-S message included the field.PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.