Skip to content

Adding provider fallback logic to CNM-R task - #4655

Closed
ThorMicah wants to merge 9 commits into
masterfrom
mthorste/CUMULUS-5883
Closed

ThorMicah wants to merge 9 commits into
masterfrom
mthorste/CUMULUS-5883

Conversation

@ThorMicah

@ThorMicah ThorMicah commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary: Summary of changes

Addresses CUMULUS-XX: Develop amazing new feature

Changes

The Provider field is an optional field to include in the CNM-S message. So data providers publishing messages without it will also not see it in the CNM-R response that is returned. That is due to how the CNM-R message is constructed, using the original CNM-S message fields (seen here).

I verified with the team that requested this feature that their data providers are not sending CNM-S messages with the Provider field.

This PR provides fall-back logic to retrieve the Provider field from the Cumulus message. It will not overwrite the field if the CNM-S message included the field.

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.

@ThorMicah
ThorMicah force-pushed the mthorste/CUMULUS-5883 branch from 5524e20 to 6d99908 Compare November 16, 2026 15:13
@npauzenga

Copy link
Copy Markdown
Contributor

@ThorMicah just a heads-up in case you're wondering. I pushed a CL update resolving a merge conflict just to trigger CI and re-deploy your stack for security.

@ThorMicah
ThorMicah force-pushed the mthorste/CUMULUS-5883 branch from 5bbadd1 to db94963 Compare November 19, 2026 18:09
@ThorMicah
ThorMicah force-pushed the mthorste/CUMULUS-5883 branch from 8f9a8a2 to 03b9c8b Compare November 19, 2026 18:12
@ThorMicah ThorMicah closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants