Repository navigation
refactor(postgres): remove branch compatibility - #769
Merged
Merged
Conversation
Drop legacy link validation and /branches redirect (now 404). Stop stripping branch parameters from metrics navigation. Remove obsolete branch regression tests.
sechmann
force-pushed
the
remove-postgres-branch-compatibility
branch
from
November 20, 2026 12:40
b39568c to
b397b01
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The supplied diffs omit the schema refresh, homeAttention.gql, homeOverview.test.ts, and activity changes, leaving the full change scope and removal of the API compatibility contract unverifiable.
No open issues 🎉
What changed in this PR
Removes legacy Postgres branch compatibility from Console’s database routes and navigation. The reviewed changes simplify database-focused behavior and remove obsolete branch-specific tests.
Changes:
- Remove legacy branch URL validation and the
/branchesredirect route. - Preserve branch query parameters during metrics navigation while retaining interval handling.
- Simplify regression tests, validate GraphQL documents against the current schema, and document database-scoped logs.
| File | Description |
|---|---|
src/routes/team/[team]/[env]/postgres/[postgres]/+layout.ts |
Remove branch URL validation. |
src/routes/team/[team]/[env]/postgres/[postgres]/(single)/queries/+page.ts |
Remove branch checks from query loading. |
src/routes/team/[team]/[env]/postgres/[postgres]/(single)/logs/+page.ts |
Remove branch checks from log loading. |
src/routes/team/[team]/[env]/postgres/[postgres]/(single)/insights/+page.ts |
Remove branch checks from insights loading. |
src/routes/team/[team]/[env]/postgres/[postgres]/(single)/branches/+page.ts |
Delete the legacy redirect route. |
src/routes/team/[team]/[env]/postgres/[postgres]/(single)/+layout.svelte |
Stop stripping branch parameters from metrics links. |
src/lib/utils/lokiLogQuery.test.ts |
Use generic application fixtures for prefix filtering. |
src/lib/domain/postgres/queryInsightsPage.test.ts |
Focus navigation tests on intervals and database filters. |
src/lib/domain/postgres/queryInsightsLoad.test.ts |
Remove legacy branch-loading expectations. |
src/lib/domain/postgres/queryInsights.test.ts |
Remove the branch-label exclusion assertion. |
src/lib/domain/postgres/PostgresTable.test.ts |
Simplify the state-rendering test name. |
src/lib/domain/postgres/postgresQueries.test.ts |
Validate documents directly against the current schema. |
src/lib/domain/postgres/overviewPage.test.ts |
Update route mocks and remove branch assertions. |
src/lib/domain/postgres/logsPage.test.ts |
Remove branch fixtures and UI assertions. |
src/lib/domain/postgres/legacyLinks.ts |
Delete the legacy branch validation helper. |
src/lib/domain/postgres/legacyLinks.test.ts |
Delete compatibility and redirect tests. |
src/lib/domain/postgres/labels.test.ts |
Point route mocks to the database overview. |
src/lib/domain/postgres/insightsPage.test.ts |
Remove branch-specific rendering checks. |
src/lib/domain/postgres/insights.test.ts |
Retain database scoping checks without branch assertions. |
src/lib/domain/persistence/Persistence.test.ts |
Keep database deduplication coverage with neutral fixtures. |
src/lib/domain/logs/LogExplorer.test.ts |
Rename filter fixture text to resource filters. |
src/lib/domain/issues/WorkloadIssuesFacets.test.ts |
Simplify Postgres issue-filter coverage. |
src/lib/domain/issues/PostgresIssue.test.ts |
Remove obsolete branch-related assertions. |
README.md |
Describe API-managed database log scope. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove remaining Postgres branch compatibility:
/branchesredirect; old links now return 404.Remove obsolete branch regression tests; retain current database-behavior coverage.
Evidence
Validation ran before rebase.
Merge Danger
Door: Two-way — revert restores compatibility.
Blast Radius: Postgres
Old
/branchesbookmarks now return 404. Branch query parameters no longer cause validation errors or affect database selection.