Repository navigation
chore(deps): drop the missing-client access-log workaround now that json-logging 1.6 fixes it - #39
Merged
Merged
Conversation
…son-logging 1.6 fixes it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json-logging 1.6.0 handles a request with no peer address on its own, so our replacement request-info extractor goes and the dependency floor moves to 1.6.
if enable_json_logging - register_client_safe_request_extractor() set json_logging logger to INFO init_fastapi / init_request_instrument / config_root_loggerPinning the
json_logginglogger to INFO stays: 1.6.0 still logs a plain-text DEBUG line during init, and the startup-only-JSON test fails without it.Evidence
test_json_logging_serves_a_request_without_a_peer_cleanlywith json-logging 1.5.1 and no workaround1 passed; full suite passes.Merge Danger
Door: two-way
Revert restores the extractor and the 1.3 floor.
Blast Radius: small
Consumers must resolve json-logging ≥ 1.6. Access-log fields are unchanged.