Skip to content

chore(deps): drop the missing-client access-log workaround now that json-logging 1.6 fixes it - #39

Merged
vinismarques merged 1 commit into
mainfrom
chore/json-logging-1-6
Oct 21, 2026
Merged

vinismarques merged 1 commit into
mainfrom
chore/json-logging-1-6

Conversation

@vinismarques

Copy link
Copy Markdown
Member

Summary

json-logging 1.6.0 handles a request with no peer address on its own, so our replacement request-info extractor goes and the dependency floor moves to 1.6.

 maestro_worker_python/
-├── request_logging.py      # extractor guarding Request.client
 └── serve.py
 tests/
-├── test_request_logging.py
 └── test_serve.py           # + serves a request without a peer cleanly
 if enable_json_logging
-  register_client_safe_request_extractor()
   set json_logging logger to INFO
   init_fastapi / init_request_instrument / config_root_logger

Pinning the json_logging logger to INFO stays: 1.6.0 still logs a plain-text DEBUG line during init, and the startup-only-JSON test fails without it.

Evidence

  • Before: test_json_logging_serves_a_request_without_a_peer_cleanly with json-logging 1.5.1 and no workaround
    AttributeError: 'NoneType' object has no attribute 'host'
    1 failed
    
    After: same test on 1.6.0 → 1 passed; full suite passes.

Merge Danger

Door: two-way

Revert restores the extractor and the 1.3 floor.

Blast Radius: small

Consumers must resolve json-logging ≥ 1.6. Access-log fields are unchanged.

@vinismarques
vinismarques merged commit df8367f into main Oct 21, 2026
1 check passed
@vinismarques
vinismarques deleted the chore/json-logging-1-6 branch October 22, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant