Repository navigation
[whisper] Remove torch from install_requires to eliminate unnecessary runtime bloat - #1458
Open
zhangcheng wants to merge 1 commit into
Open
zhangcheng wants to merge 1 commit into
zhangcheng wants to merge 1 commit into
Conversation
- Remove torch from mlx_whisper/requirements.txt to prevent pulling PyTorch during normal pip install mlx-whisper
- Add torch under extras_require={'conversion': ['torch'], 'dev': ['torch']} in setup.py
- Document in README.md that converting models requires PyTorch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
mlx-whisperdeclarestorchinwhisper/mlx_whisper/requirements.txt, making it an unconditional dependency for all users who installpip install mlx-whisper.However, during normal inference (
mlx_whisper.transcribe(...)and the CLImlx_whisper),torchis never imported or used:mlx-community/whisper-*) useweights.safetensorsor.npz, which are loaded directly into Apple Silicon unified memory viamlx.core.load.mlx_whisper/torch_whisper.py, which is solely utilized bywhisper/convert.pywhen converting raw OpenAI PyTorch checkpoints (.pt) and inwhisper/test.pyfor numerical parity verification.Having
torchas a hard runtime dependency introduces:sympy,networkx,jinja2).Changes
torchfromwhisper/mlx_whisper/requirements.txt.extras_require={"conversion": ["torch"], "dev": ["torch"]}towhisper/setup.py.whisper/README.mdto indicate thattorchis only required when converting models withconvert.pyor running parity tests.