Repository navigation
fix(python): harden write_file empty payloads and PFM handles - #9796
Open
Bartok (Bartok9) wants to merge 1 commit into
Open
Bartok (Bartok9) wants to merge 1 commit into
Bartok (Bartok9) wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
Skip writing when image payload is None/empty (simGetImage empty path), create parent dirs as needed, and use context managers for read_pfm/write_pfm so handles close on errors.
Bartok (Bartok9)
force-pushed
the
aerial/python-write-file-pfm-20260721
branch
from
October 25, 2026 21:28
032b89b to
2e624f8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_fileis used by almost every image sample. WhensimGetImagereturns empty/None/\0, callers could create bad files or throwTypeError.withopen forread_pfm/write_pfmso handles always closeMotivation
Empty camera responses should not break sample scripts mid-save.
Verification
PythonClient/airsim/utils.py(orthogonal to the frombuffer helper PR)Claim: bartok
Operator: bartok
Campaign: aerial-drone