Repository navigation
Fix: import command to honor --microcksURL without login - #510
Syedowais312 wants to merge 1 commit into
Conversation
12cb5c0 to
88f6616
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
@Syedowais312 Please again take a look on this PR. Need some work as new changes are there in the code for Microcks client. |
Signed-off-by: syedowais312 <syedowais312sf@gmail.com>
88f6616 to
0bb6d71
Compare
|
@Harsh4902 I rebased the PR onto the latest master and have kept all the original changes, and pushed the updated branch. It now uses the latest Microcks client changes. |
Summary
This updates
microcks importto use the shared command client setup already used byimport-dir,service, andtest.Previously,
microcks import --microcksURL ...still required local config/login unless Keycloak client credentials were also provided. This was inconsistent withimport-dirand broke locallatest-nativeusage where Keycloak is disabled.Changes
newCommandClient(globalClientOpts)in theimportcommand.--watchcontext selection by falling back to the current config context, then the provided server URL.import --microcksURL --config <empty>reaches the artifact upload endpoint.Verification
fix: #511