Skip to content

Fix: import command to honor --microcksURL without login - #510

Open
Syedowais312 wants to merge 1 commit into
microcks:masterfrom
Syedowais312:fix/import-microcksurl-without-login
Open

Syedowais312 wants to merge 1 commit into
microcks:masterfrom
Syedowais312:fix/import-microcksurl-without-login

Conversation

@Syedowais312

@Syedowais312 Syedowais312 commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This updates microcks import to use the shared command client setup already used by import-dir, service, and test.

Previously, microcks import --microcksURL ... still required local config/login unless Keycloak client credentials were also provided. This was inconsistent with import-dir and broke local latest-native usage where Keycloak is disabled.

Changes

  • Reuse newCommandClient(globalClientOpts) in the import command.
  • Preserve --watch context selection by falling back to the current config context, then the provided server URL.
  • Add a regression test verifying import --microcksURL --config <empty> reaches the artifact upload endpoint.

Verification

go test ./cmd
go test ./...
image

fix: #511

@Syedowais312

Copy link
Copy Markdown
Contributor Author

cc: @Vaishnav88sk @Harsh4902 @lbroudoux

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions Bot added the stale State due to inactivity label Sep 27, 2026
@Harsh4902 Harsh4902 added keep-open Explicitily keep open and removed stale State due to inactivity labels Sep 28, 2026
@Harsh4902

Copy link
Copy Markdown
Member

@Syedowais312 Please again take a look on this PR. Need some work as new changes are there in the code for Microcks client.

Signed-off-by: syedowais312 <syedowais312sf@gmail.com>
@Syedowais312
Syedowais312 force-pushed the fix/import-microcksurl-without-login branch from 88f6616 to 0bb6d71 Compare October 10, 2026 19:33
@Syedowais312

Copy link
Copy Markdown
Contributor Author

@Harsh4902 I rebased the PR onto the latest master and have kept all the original changes, and pushed the updated branch. It now uses the latest Microcks client changes.

This branch was successfully deployed

1 active deployment
Build — 0bb6d714 Deployed Oct 10, 2026 by Syedowais312 via build-verify-package #794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep-open Explicitily keep open

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import command requires login even when --microcksURL is provided

2 participants