Repository navigation
Fix routing documentation test and restore live chat output - #5057
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aba68bbdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fmt.Fprintln(d.terminal.Stdout(), renderMarkdown(text[:end], width)) | ||
| d.markdown.Reset() | ||
| d.markdown.WriteString(text[end:]) |
There was a problem hiding this comment.
When a reply uses reference-style Markdown links, rendering each completed paragraph as a separate document loses the definitions needed to resolve those links. For example, streaming [Docs][docs]\n\n followed by [docs]: https://example.com\n prints the unresolved reference first, then renders the definition separately without displaying its URL. Previously, rendering the complete reply resolved the link correctly. Preserve document-level reference context, or defer rendering content whose references are unresolved, so valid replies do not lose their links.
Useful? React with 👍 / 👎.
Run Tests fails because the README check still requires the phrase
registered agents, which was removed when chat routing became explicit. Check the documentedmicro chat NAME,/agent NAMEand/agent microcommands instead.Restore progressive Markdown output without putting reply text inside readline's editable prompt. Print completed paragraphs and fenced code blocks once as they arrive, then print the unfinished remainder on completion. Keep incomplete command output out of the prompt too. This avoids the repeated wrapped previews that previously polluted scrollback; short replies without a complete block still appear at completion.
Validation:
go build ./...,go vet ./cmd/micro/chatand chat race tests pass.make chat-smokepasses. A new real PTY test uses an 8-row, 42-column terminal, streams paragraphs/code while the provider waits, queues a follow-up, and verifies every reply marker appears once.netlinkrib: operation not permitted); full validation remains for GitHub CI.