Repository navigation
feat: let mention results be listed but not picked - #9
Merged
Merged
Conversation
Hosts sometimes need to show a candidate that cannot be mentioned in the current context, such as an agent that needs resources the conversation lacks. Hiding it leaves people guessing why it is missing. Mention options accept disabled and description. Keyboard navigation and the initial highlight skip disabled options, confirm and insert refuse them, and the registry menu renders them with aria-disabled and the description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts sometimes need to show a mention candidate that cannot be picked in the current context. One example is an agent that needs resources the conversation does not have. Hiding the candidate leaves people guessing why it is missing. Showing it disabled, with the reason, explains the situation.
Mention options now accept
disabledanddescription:confirmMention$andinsertMention$refuse disabled options, so Enter, Tab, and click never insert them. If every result is disabled, the menu stays open.aria-disabled, muted text, and the description. It does not highlight them on hover.The mentions guide documents the fields, and the mentions story includes a disabled person.