Repository navigation
fix: show loading while a command search is pending - #10
Merged
Merged
Conversation
The command shelf showed "No commands" while a slow provider was still searching. The plugin sets the loading flag from inside its menu subscription. reactive-engine-core 0.1.2 then finished the outer propagation with a stale snapshot, so the combined cell behind useCellValues ended with loading false while the cell itself was true. reactive-engine-core 0.2.1 keeps the nested update, so upgrade the core and its React bindings (1.0.0). Browser tests cover the pending state of the command shelf and the mention menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a slash-command provider was still searching, the command shelf showed "No commands". Hosts with slow providers looked empty instead of loading.
The plugin sets
slashCommandLoading$from inside itsslashCommandMenu$subscription. In reactive-engine-core 0.1.2, the outer propagation then finished with a stale snapshot. The combined cell behinduseCellValuesended withloading: false, even though the cell itself wastrue. reactive-engine-core 0.2.1 keeps the nested update.This PR upgrades
@virtuoso.dev/reactive-engine-coreto 0.2.1 and@virtuoso.dev/reactive-engine-reactto 1.0.0, which requires core >=0.2.0. No library code needed to change. New browser tests cover the pending state of the command shelf and of the mention menu. The mention menu was not affected; its test guards against regressions.