Skip to content

fix: show loading while a command search is pending - #10

Merged
petyosi merged 1 commit into
mainfrom
petyosi/menu-loading-state
Oct 12, 2026
Merged

petyosi merged 1 commit into
mainfrom
petyosi/menu-loading-state

Conversation

@petyosi

@petyosi petyosi commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

While a slash-command provider was still searching, the command shelf showed "No commands". Hosts with slow providers looked empty instead of loading.

The plugin sets slashCommandLoading$ from inside its slashCommandMenu$ subscription. In reactive-engine-core 0.1.2, the outer propagation then finished with a stale snapshot. The combined cell behind useCellValues ended with loading: false, even though the cell itself was true. reactive-engine-core 0.2.1 keeps the nested update.

This PR upgrades @virtuoso.dev/reactive-engine-core to 0.2.1 and @virtuoso.dev/reactive-engine-react to 1.0.0, which requires core >=0.2.0. No library code needed to change. New browser tests cover the pending state of the command shelf and of the mention menu. The mention menu was not affected; its test guards against regressions.

The command shelf showed "No commands" while a slow provider was still
searching. The plugin sets the loading flag from inside its menu
subscription. reactive-engine-core 0.1.2 then finished the outer
propagation with a stale snapshot, so the combined cell behind
useCellValues ended with loading false while the cell itself was true.

reactive-engine-core 0.2.1 keeps the nested update, so upgrade the core
and its React bindings (1.0.0). Browser tests cover the pending state of
the command shelf and the mention menu.
@petyosi
petyosi merged commit 83b5dd5 into main Oct 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant