Repository navigation
2.1.2: the reference v2.1.1 rulings (U3, U6, U9, U15) - #28
Merged
Merged
Conversation
- Re-vendor from mas-bandwidth/serialize v2.1.1 (no corpus change) and move the interop pin SERIALIZE_REF to v2.1.1. - U15: SerializeUtil.copyString, serialize_copy_string on the strict UTF-8 encoding; destSize < 1 and a lone surrogate assert under -ea (U9). - U9/U10: every multi-group write (bits64, int64, int128, uint128, double, fixed, fixed128, int_relative) asserts the room for the whole operation before its first bit; before, a wide value could leave its low group on the wire ahead of the assertion. - U15 exports: compressedFloatMaxIntegerValue, compressedFloatDeclarationIsValid and compressedFloatConstantsAreConsistent are package-private now. - U3/U9 docs: '?'/U+FFFD and the compressed_float clamp without -ea are unspecified output, never documented behaviour; the write-misuse contract names the trap and cites U9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the rulings of mas-bandwidth/serialize v2.1.1 (IMPLEMENTING.md U3, U6, U9, U15).
SerializeUtil.copyString( source, destSize ), on the strict UTF-8 encoding; destSize < 1 and a lone surrogate are write misuse (AssertionError under -ea). Every reference vector except the two ill-formed byte vectors a Java String cannot hold. Tests:U15: copyString keeps the longest whole-character UTF-8 prefix...,U9 U15: copyString with destSize below 1, or a lone surrogate....U9 U10: every operation that does not fit the room left asserts before writing any bit, and latches nothing(red before the fix).🤖 Generated with Claude Code