Repository navigation
fix(bootstrap): isolate generated code from init output - #446
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Signed-off-by: Виктор Быстров <anatema@bk.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output from an imported package's
init()currently shares stdout with generated source. Normal generation then fails in gofmt, while-noformatsaves invalid Go code.Write bootstrap output to a dedicated file and make
gen.Run(writer)send both its header and body to that writer. Header write errors are propagated, and the output file is closed before formatting or renaming. Standalone bootstrap execution without an output filename keeps its stdout behavior. Add the bootstrap package to the existing Makefile test target so CI runs the regression.Fixes #340.
The earlier header-writer proposal in #226 is related prior work; this change also isolates bootstrap output end to end.
Validation on Go 1.23.0:
-noformatgeneration with a noisy dependency fail before the fix and pass afterward; generated code compiles and round-trips JSON.make(including the new bootstrap target, generation, tests, benchmarks, and golint),go test -race -count=1 ./..., andgo vet ./...passed.