Repository navigation
Conversation
brgoing
force-pushed
the
bgoing/fuzz-device-plugins
branch
from
October 30, 2026 19:52
766add2 to
1b695d7
Compare
brgoing
changed the title
brgoing
force-pushed
the
bgoing/fuzz-device-plugins
branch
from
October 30, 2026 19:54
1b695d7 to
69d0d89
Compare
A device target run spreads its time across every command in the table, so it takes a long time to reach deep coverage of any one plugin. Add a --plugins option to nvme-fuzz run that limits the device target to the commands of the named plugins or built-in commands, e.g. --plugins ocp,micron. With --plugins and no --targets, run only the device target; reject --plugins when --targets ommits device. Make the device target read the selection from FUZZ_PLUGINS and reject inputs of other commands, so libFuzzer keeps them out of the corpus. Exit with an error on a name that matches no command, or on a list that names none. Run the selected commands on a copy of their inputs from the corpus, since a merge with FUZZ_PLUGINS set would drop every other command's inputs. Seed the copy with one input per selected command that has no device data, for each PCI ID its plugin checks, and add what the run finds back to the corpus when it ends. Drop an exported FUZZ_PLUGINS from the environment of the fuzz jobs, merges and replays, so that only --plugins sets it. Add a matching --fuzz-plugins option to scripts/build.sh, and document the option in TESTING.md. Signed-off-by: Broc Going <bgoing@micron.com>
11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A device target run spreads its time across every command in the table, so it takes a long time to reach deep coverage of any one plugin.
Add a --plugins option to nvme-fuzz run that limits the device target to the commands of the named plugins or built-in commands, e.g. --plugins ocp,micron. With --plugins and no --targets, run only the device target; reject --plugins when --targets ommits device.
Make the device target read the selection from FUZZ_PLUGINS and reject inputs of other commands, so libFuzzer keeps them out of the corpus. Exit with an error on a name that matches no command, or on a list that names none.
Run the selected commands on a copy of their inputs from the corpus, since a merge with FUZZ_PLUGINS set would drop every other command's inputs. Seed the copy with one input per selected command that has no device data, for each PCI ID its plugin checks, and add what the run finds back to the corpus when it ends. Drop an exported FUZZ_PLUGINS from the environment of the fuzz jobs, merges and replays, so that only --plugins sets it.
Add a matching --fuzz-plugins option to scripts/build.sh, and document the option in TESTING.md.
Changes were suggested in #4305