Repository navigation
Conversation
Signed-off-by: Apoorv Kothari <apoorv@buoyant.io>
Revert "chore: drop cflags here, covered by dev container" (4fae0b5). We restore the arm64 linker override to test whether the v54 dev image alone fixes the musl link, with the override in place. Signed-off-by: Apoorv Kothari <apoorv@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps every linkerd/dev image and action ref from v53 to v54.
v54 fixes the musl C toolchain: musl
CFLAGS_<target>now reach the kernel headers while keeping-nostdinc, soaws-lc-sysbuilds for bothx86_64-unknown-linux-muslandaarch64-unknown-linux-musl.The second commit restores the
AWS_LC_SYS_CFLAGSoverride inDockerfile-cni-plugin(reverting 4fae0b5) to test whether the v54 image alone fixes the musl link with the override in place.Previous dev bump for comparison: #854