[DerekFrank]

What

Since v0.25.0 the typed client decodes the delete response (controller-runtime#3472). For a PartialObjectMetadata of a kind that isn't in the client's scheme, that decode fails whenever the server returns the object, for example when finalizers hold it. The caller gets no kind "..." is registered even though the delete succeeded.

PartialObjectMetadata deletes now go through the unstructured client, which decodes any kind.

I only ran into this working on an update to Delete() that stores the response, I'm not actually sure if it can hit anyone in practice

Tests

A regression test in client_test.go deletes a ChaosPod held by a finalizer through a client whose scheme doesn't have ChaosPod. It fails without this change.

Release note: Fix Delete of PartialObjectMetadata for kinds not in the scheme returning an error after the object was deleted.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DerekFrank
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment