Repository navigation
Merge 0.0.8 release from mvp_demo to main - #168
Conversation
Signed-off-by: kruize-version-sync <2884050+kruize-version-sync[bot]@users.noreply.github.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
build(deps): update Kruize image versions
…ition PR check: wait for Prometheus CRDs to be established before applying manifests
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: kruize-version-sync <2884050+kruize-version-sync[bot]@users.noreply.github.com>
build(deps): update Kruize image versions
Signed-off-by: kusuma chalasani <kchalasani@ibm.com>
docs: add CONTRIBUTING.md for kruize-operator
Signed-off-by: kusuma chalasani <kchalasani@ibm.com>
Update version to 0.0.8
Reviewer's GuideUIAdd a Slack community link and QR code to the README's contribution section.
ConfigurationBump the operator release version to 0.0.8 across the bundle, manager image configuration, and Makefile default.
Update the default Autotune and optimizer image versions in the sample and operator constants, alongside the bundle's corresponding image settings.
Wait for the specific Prometheus CRDs to become established before applying Prometheus manifests.
DocumentationDocument the contribution workflow, build and test steps, commit conventions, and project resources.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="bundle/manifests/kruize-operator.clusterserviceversion.yaml" line_range="105" />
<code_context>
repository: https://github.com/kruize/kruize-operator
support: Kruize Community
- name: kruize-operator.v0.0.7
+ name: kruize-operator.v0.0.8
namespace: placeholder
spec:
</code_context>
<issue_to_address>
**Existing installations cannot upgrade**
When an OLM catalog contains both the previously released 0.0.7 bundle and this 0.0.8 bundle, the 0.0.8 CSV has no upgrade edge from 0.0.7, so OLM cannot resolve the upgrade and existing installations remain on the old release.
Set the 0.0.8 CSV to replace the 0.0.7 bundle.
</issue_to_address>
### Comment 2
<location path=".github/workflows/pr-check.yaml" line_range="112" />
<code_context>
+ customresourcedefinitions.apiextensions.k8s.io/podmonitors.monitoring.coreos.com \
+ customresourcedefinitions.apiextensions.k8s.io/probes.monitoring.coreos.com \
+ customresourcedefinitions.apiextensions.k8s.io/prometheuses.monitoring.coreos.com \
+ customresourcedefinitions.apiextensions.k8s.io/prometheusagents.monitoring.coreos.com \
+ customresourcedefinitions.apiextensions.k8s.io/prometheusrules.monitoring.coreos.com \
+ customresourcedefinitions.apiextensions.k8s.io/scrapeconfigs.monitoring.coreos.com \
</code_context>
<issue_to_address>
**PR check stops before applying manifests**
When the PR check runs on a fresh cluster with the pinned kube-prometheus v0.13.0 setup, `kubectl wait` targets the `prometheusagents.monitoring.coreos.com` CRD, which the setup does not install, so the command exits nonzero and the workflow stops before applying the Prometheus manifests.
Remove the `prometheusagents.monitoring.coreos.com` CRD from the wait targets or ensure the setup installs it.
</issue_to_address>
### Comment 3
<location path="CONTRIBUTING.md" line_range="134" />
<code_context>
+## Code Style and Guidelines
+
+- Follow standard [Go conventions](https://google.github.io/styleguide/go/)
+- Run `gofmt` before committing: `gofmt -w ./...`
+- Keep changes focused — one logical change per commit and per PR
+- Add or update documentation in `docs/` for non-trivial changes
</code_context>
<issue_to_address>
**Documented formatting command fails**
When a contributor runs the documented command from the repository root, `gofmt -w ./...` treats `./...` as a literal path, not a Go package pattern, and exits because that path does not exist, so contributors cannot complete the documented formatting step.
Replace the command with one that passes Go source file paths to `gofmt`.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: bundle/manifests/kruize-operator.clusterserviceversion.yaml:105, .github/workflows/pr-check.yaml:112
Merge 0.0.8 release from mvp_demo to main
Summary by Sourcery
Publish the 0.0.8 operator release with updated component images, contributor documentation, and more reliable Prometheus setup checks.
Bug Fixes:
Enhancements:
CI:
Documentation:
Chores: