Repository navigation
Conversation
Use version_compare() for the SHOW BINARY LOG STATUS switch so MySQL 9.x and 26.x get it too, and skip MariaDB, whose 10.x/11.x version string would otherwise compare as newer than MySQL 8.4. Add MySQL 9.7 (LTS) and 26.10 to the CI matrix. Co-authored-by: Denis Zunke <1244235+DZunke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #146 by @DZunke, thank you; this also fixes the matrix so each job runs its own MySQL version, which the maintainer noted. Supersedes #146.
Changes
MySQLRepository::getMasterStatus()usesversion_compare()(asBinLogSocketConnectalready does), so MySQL 9.x and 26.x getSHOW BINARY LOG STATUS.SHOW MASTER STATUSwas removed in MySQL 8.4, so on 9.x the oldstr_starts_with('8.4')check broke every connection that starts without a binlog position.SHOW MASTER STATUS. Without a MariaDB guard,version_compare()treats11.4.13-MariaDBas newer than 8.4.0 and sendsSHOW BINARY LOG STATUS, which MariaDB rejects. That was the cause of the 8 red MariaDB jobs on Support MySQL 9.0 in CI #146.9.7(LTS) and26.10(latest), both of whichshogo82148/actions-setup-mysqlsupports now (its README lists 26.10, 26.7, 9.7 LTS and 8.4 LTS).Matrix: one version per job
On current master each job already installs and tests its own server. The setup step installs from
/opt/hostedtoolcache/mysql/<version>, andBaseCaseprints>> Tests running against MySQL server version: …(added after #146 was opened), for example5.7.44-log,8.4.13and11.4.13-MariaDB-login the jobs of a recent run. The new 9.7 and 26.10 jobs print the same line, so each job's log shows which server it ran against.Local results (Docker, PHP 8.4, full suite)
SHOW MASTER STATUS)SHOW BINARY LOG STATUS)PHPStan: no errors.
The PHP 8.2 jobs need #159 (PHPUnit 11.5 for PHP 8.2) to install; this PR does not depend on it otherwise.
Sources: MySQL 8.4 release notes: SHOW MASTER STATUS removed, SHOW BINARY LOG STATUS, MariaDB SHOW BINLOG STATUS / SHOW MASTER STATUS, actions-setup-mysql supported versions.
🤖 Generated with Claude Code