Repository navigation
feat: authored carousel and chart - #49
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The last two ordinary shadcn/ui names kosori did not serve:
carouselandchart. Both are Authored components under ADR-0008 — Structure from shadcn/ui, Design inherited from the nearest Port, no upstream pin.With these, every non-AI shadcn/ui component is served. The only gaps left are the chat family and
sonner.carouselembla-carousel-react@8.6.0,@kosori/buttonregistry dependencyCarousel,CarouselContent,CarouselItem,CarouselPrevious,CarouselNext,useCarousel,CarouselApiButton(outline,icon-sm); slides useaspect-ratio; no dot indicators, because base-nova has none and adding them would be inventioncn-rtl-flipdoes not exist in this repo; replaced withrtl:-scale-x-100chartrecharts@3.10.1andreact-is@19.3.1— Recharts declaresreact-isas a required peer and it is absent from a default tree, so copying shadcn's manifest would ship a broken installcardregistry dependency: the source never imports itpopover, muted labels frommuted-foreground, series colours from the existing--chart-1..5Verification
bun run check— cleanbun run check-types— cleanbun test— 45 pass, 0 fail, 2796 assertionsbun run registry:build— cleanJanuary / Desktop 186 / Mobile 80), popover surface in both schemesNotes
bun.lockalso movedreselectto 5.2.0 at the top level with a nested 5.3.0, a consequence of the Recharts pin.