Repository navigation
refactor(web): mirror shadcn render plumbing across zen components - #34
Merged
Merged
Conversation
Drop table's hand-written render and compose pagination links with Button, matching shadcn's Base UI structure. Add the render type fixture covering pagination, progress, radio-group, separator, skeleton, slider, spinner, switch, table, textarea and toast.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Mirrors shadcn/ui's render plumbing across all 47 zen components while keeping every coss class string. Structure follows shadcn; the visual layer stays coss.
What changed
Twelve components needed a change; the other 35 already matched shadcn.
useRender+mergePropsButton, inheritsPrimitive.PropsuseRenderon all 13 exportsdivwrappersuseRender(Base UI label)<label>InputPrimitive.PropsReact.ComponentProps<'input'>;renderdroppedrender={<Separator/>}SeparatoruseRenderdivpropsuseRenderdivpropsuseRender; nine hand-writtenrenderslotsrenderPaginationLinkviauseRenderButtonwithrender={<a/>}; publicrenderdroppeduseRender+ hand-writtenrender?div+tableExamples keep using
renderwhere shadcn's demos do.Recorded decisions
docs/adr/0007-render-plumbing.md: zen mirrors shadcn's render structure; styling stays coss.VERSION.md: pins hash upstream styling bytes, not a diffable local copy.Verification
main(scripted comparison).render?:declaration remains underregistry/zen/ui.test/fixtures/render/batch-{a,b,c}.tsx) assert accepted and rejected cases at compile time.check,check-types, registry build and a productionnext buildall pass.