Repository navigation
fix(recipes): drop dead ffmpeg --disable-everything flag - #3385
Merged
AndreMiras merged 1 commit intoOct 12, 2026
Merged
Conversation
AndreMiras
reviewed
Oct 12, 2026
AndreMiras
requested changes
Oct 12, 2026
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
Thanks for the clean up, that was dead code and confusing.
Let's completly drop the disable-everything to preserve the expected runtime behavior.
The ffmpeg recipe set flags = ['--disable-everything'] and then immediately reassigned flags to the JNI/MediaCodec list, so the disable-everything line was dead code (issue #3382). Remove it instead of re-enabling it: existing apps rely on FFmpeg's default components, including the MediaCodec decoders and the HLS demuxer. Keep the hardware acceleration flags in get_base_configure_flags(), update the comments, and cover the behaviour with a unit test. Fixes #3382
r3wretrhy
force-pushed
the
fix/ffmpeg-disable-everything-3382
branch
from
October 12, 2026 11:53
b913e38 to
602bda4
Compare
r3wretrhy
changed the title
|
coverage: 63.259% (+0.02%) from 63.235% — r3wretrhy:fix/ffmpeg-disable-everything-3382 into kivy:develop |
AndreMiras
approved these changes
Oct 12, 2026
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the quick follow up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ffmpeg recipe set
flags = ['--disable-everything']then immediately reassignedflagsto the mediacodec/jni list, so the--disable-everythingline was dead code (issue #3382).Per review, drop it rather than re-enabling it: existing apps rely on FFmpeg's default components (including the MediaCodec decoders and the HLS demuxer in the default build), so runtime behaviour stays as it is today. The hardware acceleration flags live in
get_base_configure_flags(), the comments are updated, and a unit test covers the behaviour.Fixes #3382
Test plan
pytest tests/recipes/test_ffmpeg.py— 1 passedpytest tests/recipes— 85 passedflake8on the changed files — clean