Repository navigation
end2end tests: attach browser diagnostics to failure reports - #538
Merged
Merged
Conversation
Add a `pytest_runtest_makereport` hook that records the current URL, title, and a body-text excerpt when a browser test fails. Preserve partial diagnostics and report collection errors alongside the original failure when the browser is unavailable.
… needed Import `selenium` after checking for a `driver` fixture in `pytest_runtest_makereport`, so loading `tests/conftest.py` does not require browser dependencies in the normal test environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
pytest_runtest_makereporthook that records the current URL, title, and a body-text excerpt when a browser test fails.Preserve partial diagnostics and report collection errors alongside the original failure when the browser is unavailable.