Repository navigation
end2end tests: probe bridge readiness without a DOM marker - #537
Merged
Merged
Conversation
Page scripts can remove the DOM attribute used to signal that `selenium_bridge.js` is ready, leaving tests waiting on an active bridge. Use a cancelable `selenium-bridge-ping` event and `dispatchEvent()`'s return value to acknowledge readiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page scripts can remove the DOM attribute used to signal that
selenium_bridge.jsis ready, leaving tests waiting on an active bridge.Use a cancelable
selenium-bridge-pingevent anddispatchEvent()'s return value to acknowledge readiness.