Repository navigation
Conversation
Resolve the given repo to the concrete repo Xray tracks before querying it: a remote repo maps to its cache repo and a virtual repo to the member repo that holds the artifact. Multi-arch docker images are expanded into their platform manifests, so a blocked platform marks the image as blocked. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....jf xr statusonly worked when the given repo was a local repo. Xray indexes concrete repos only (local repos and the-cacherepo behind a remote one), so remote and virtual keys returned a misleadingUNKNOWNor a 404. The command now resolves the repo type itself, so the same command and arguments work for every repo type.Changes
resolve.go. The given repo is resolved to the concrete repo Xray tracks before any Xray call.index.go. A multi-arch docker image (manifest list) is expanded into its platform manifests.requested_repoin JSON,Resolved Fromin the table).Resolution
-cacherepo, taken from the storage API response<remote>-cachekeyIf the repo configuration can't be read, the key is probed as a concrete repo. A member that returns 403 or 404 is skipped, any other error is returned.
Multi-Arch Docker Images
Xray scans each platform manifest (
<image>/sha256__<digest>/manifest.json) and the manifest list carries no violations of its own. Before this change a multi-arch image was reported asALLOWEDeven when a platform manifest was blocked.When the resolved path is a
list.manifest.json, each platform manifest present in the repo is evaluated and the worst status wins (BLOCKED, thenUNKNOWN, thenALLOWED). Attestation manifests are skipped. The output gains aplatformsarray and aplatformfield on each violation. Only platforms present in the repo are checked.Verification
Verified on a live platform with new Maven and docker local, remote and virtual repos and a blocking policy.
BLOCKED<remote>-cacheBLOCKED(wasUNKNOWN)BLOCKED(was 404)<remote>-cacheBLOCKED(was 404)BLOCKED<remote>-cache, platform manifestBLOCKED(wasALLOWED)