Repository navigation
Declare Linux transport dependencies explicitly - #199
Merged
Merged
Conversation
Declare the SwiftNIO products imported by the Linux adapter and verify both locked and freshly resolved dependencies in clean Linux CI builds.
Remove redundant returns from three files so the full repository lint check passes with the current formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux consumers can fail to build with
no such module NIOFoundationCompatbecause the transport imports SwiftNIO products without declaring them in its target dependencies. Declare the three imported products for Linux, using a version range compatible with the existing AsyncHTTPClient minimum.Keep the existing locked-dependency Linux job and add a Swift 6.2 job that resolves current compatible dependencies. Both perform a clean library build before running tests, so cached modules cannot conceal missing dependencies. The package's Swift tools version and Apple deployment targets stay the same. Apply the current formatter's implicit-return style in three existing files so the full repository lint check passes.
Validation: