Repository navigation
be more conservative syncing dependencies of conflicts with alternate lockfiles - #71
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Transitive replacements can retain incompatible dependencies, forcing remote resolution or breaking local synchronization.
What changed in this PR
Makes alternate-lockfile synchronization more conservative by checking requirements from gems outside the conflict set before adopting parent versions.
Changes:
- Cache dependency requirements by dependent gem.
- Use filtered requirements when choosing parent versions.
- Add regression coverage for conservative shared-gem updates.
| File | Description |
|---|---|
| spec/bundler/multilock_spec.rb | Tests preserving Rails versions during shared-gem updates. |
| lib/bundler/multilock/cache.rb | Tracks and filters dependent requirements. |
| lib/bundler/multilock.rb | Checks requirements before adopting parent versions. |
Review effort: Balanced
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 00:32
1a17d76 to
4e950ef
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 00:55
4e950ef to
73fc877
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 15:48
73fc877 to
f9080eb
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 16:12
f9080eb to
cd2dbea
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 16:32
cd2dbea to
bead6f1
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 16:52
bead6f1 to
ab869a0
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 17:56
a7884ac to
02cf1bb
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 18:09
02cf1bb to
f376d7d
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 18:22
f376d7d to
bd849da
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 18:38
bd849da to
1b75720
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 18:51
1b75720 to
0be94b5
Compare
ccutrer
force-pushed
the
conservative-sync
branch
from
October 20, 2026 19:06
0be94b5 to
87ff1d1
Compare
maths22
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.