Skip to content

fix(domains): a new domain is offered in "Show configs of" at once - #155

Merged
hiddify-com merged 1 commit into
hiddify:devfrom
Hiddify-Official:fix/show-domains-cdn
Nov 1, 2026
Merged

hiddify-com merged 1 commit into
hiddify:devfrom
Hiddify-Official:fix/show-domains-cdn

Conversation

@Hiddify-Official

Copy link
Copy Markdown
Contributor

Problem

Admins add a domain (e.g. CDN with valid TLS), open a domain's edit dialog to limit its sub link to it, and the new domain is not in Show configs of. Often the list is empty ("No available options").

Root cause: that list only came with domains-page/options/, which also works out the compatible proxies for every mode × TLS mode. That takes about 5 s on the test server. The page asks for it again after every change, so a dialog opened in the meantime shows the old list or none. _show_options itself was always complete: CDN domains were never filtered.

Change

  • domains_page_api.py: _list_out adds show_options, which takes about 10 ms. It goes with every domains list: load, add, edit, delete and reorder. The options call still returns it too.
  • api.ts, DomainDialog.vue, DomainsView.vue: the dialog, and the "Show configs of" labels on the rows, read state.show_options first and fall back to the options call.

Screenshots

The edit dialog opened right after the page loaded, with a test CDN domain (valid TLS) present:

Before After
before after

Tested

  • On main, with a test CDN/valid domain added and then removed:
    • Before: the dialog opened right after load showed an empty list. Opened after the options answer (about 4.6 s), it had all 19 domains, which confirms the timing.
    • After: the list is there at once and includes the CDN domain.
  • No errors in the panel log after the restart. vue-tsc: no errors in the changed files.
  • Not changed: the options call is still slow, because of _compatible_proxies. Until it answers, the custom-proxies choice offers every proxy, which was already the case.

Review

  • Confidence: High (>90%) — the cause was reproduced and measured; the change adds one field to the list response and reads it.
  • Complexity: Simple — the Domains page and its list serializer.

🤖 Generated with Claude Code

…once

The edit dialog's "Show configs of" list came only with the options call,
which takes seconds (it works out the proxies that fit each kind of
domain: about 5 s on the test server) and was asked again after every
change. A domain just added (e.g. a CDN domain with valid TLS) was missing
from the list, or the list was empty, when the dialog was opened before
that answer.

The list is quick to build (10 ms), so it now comes with every domains
list (load, add, edit, delete, reorder) and the dialog uses it; the options
call still sends it for older pages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hiddify-com
hiddify-com merged commit 51cfbe4 into hiddify:dev Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants