Repository navigation
v3 circuit breaker - #683
Merged
Merged
Conversation
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
Code Coverage
|
kacper-kozera
force-pushed
the
feature/v3-circuit-breaker
branch
from
November 3, 2026 10:18
419d0f6 to
0aad6d0
Compare
Code Coverage
|
Marcin-Here
reviewed
Nov 5, 2026
| case ffwAdapter -> | ||
| new ErrorResponse(NakshaError.NOT_IMPLEMENTED, "Writing not supported by underlying storage"); | ||
| case dataHubConnector -> | ||
| new ConnectorInterfaceWriteExecute(getNakshaContext(), request, getRequestSender()).execute(); |
Contributor
There was a problem hiding this comment.
I think we need also to move default as we did in ReadSession
Author
There was a problem hiding this comment.
I removed the default and converted the ReadSession switch to a switch expression, consistent with the write switch.
| || cbConfig.getSlowCallRateThreshold() == null | ||
| || cbConfig.getWaitDurationInOpenStateMs() == null | ||
| || cbConfig.getPermittedNumberOfCallsInHalfOpenState() == null) { | ||
| throw new IllegalArgumentException("circuitBreaker configuration is iconcomplete"); |
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
rlakde
requested changes
Nov 6, 2026
| "headers": { | ||
| "Authorization": "Bearer token123" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
Let us stick with "circuitBreakerConfig" everywhere. There is an issue with v2 implementation and already raised a MR for this.
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| "Authorization": "Bearer <token>", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "circuitBreaker": { |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
| private static final String HEADERS = "headers"; | ||
|
|
||
| private static final String HTTP_INTERFACE = "httpInterface"; | ||
| private static final String CIRCUIT_BREAKER = "circuitBreaker"; |
Member
There was a problem hiding this comment.
"circuitBreakerConfig" instead of "circuitBreaker"
Signed-off-by: Kacper Kozera <kacper.kozera@here.com>
Code Coverage
|
rlakde
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.