Repository navigation
Implement sliceOfShortByteString - #724
Merged
Merged
Conversation
Contributor
|
@vdukhovni could you please rebase? I've fixed CI configuration. |
Bodigrim
approved these changes
Oct 31, 2026
vdukhovni
force-pushed
the
sliceOfShortByteString
branch
from
November 1, 2026 01:09
bd3a579 to
b476790
Compare
Contributor
|
Thanks! |
sjakobi
reviewed
Nov 2, 2026
Comment on lines
+1077
to
+1078
| | len >= 0 && off + len <= Sh.length sbs | ||
| = builder $ shortByteStringCopyStep sbs off len |
Member
There was a problem hiding this comment.
Sorry, for the late review, but I wonder if it might be good to check for negative offsets too?!
Contributor
Author
There was a problem hiding this comment.
You're perhaps right, that's an omission. A negative offset for some reason feels like a less likely error, but there's no science behind this. With the PR merged, the additional bounds check would be a new PR? Care to author it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664