Repository navigation
chore(runner): flip SENTRY_SCOPE and VITE_SENTRY_SCOPE to uncaught (DEV-3099) - #432
Merged
Merged
Conversation
Narrows Sentry to errors that escape a handler; handled diagnostics go only to Grafana/Loki. Rollback is setting both back to full. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
DEV-3099: narrow Sentry to errors that escape a handler. This flips
SENTRY_SCOPEon the API worker (runner/workers/api/wrangler.jsonc) andVITE_SENTRY_SCOPEin the authoring production build (.github/workflows/master.yml) fromfulltouncaught. Handled diagnostics then go only to Grafana/Loki.The preconditions in DEV-3094 are met and go was recorded on 2026-10-12: real data end to end, alerts fired for real, alert windows retuned (#429), fingerprint feed cleaned up (#430), 422
build_failedcapture dropped (#431), Tier-2 output probe clean, volume at about 0.5M events a month against a 5M target.Known gap, accepted: a fresh post-#430 production probe of the API-side new-fingerprint feed was not possible (the
npm-registry:*paths only fire when the registry fetch throws). It is covered bypipeline/o11y-normalise.test.mjs, and the first natural new API handled-error class after the flip is the live confirmation. A new class is only a row in the "New handled-error fingerprints (first seen)" table on Observability self, with no Slack post (decided in DEV-3094).Rollback: set both values back to
full(a revert of this PR does exactly that), merge and let the API worker and the authoring build deploy. No code change is needed. Sentry resumes receiving handled diagnostics on the next deploy of each half.The
run-and-deploy.mdrunbook now says the committed values readuncaught.api-telemetry-config.test.mjspinnedSENTRY_SCOPEtofull, so it now pinsuncaught, and a newmaster-workflow.test.mjspin covers the authoring half so the two halves cannot drift apart.Types of changes
runner/) changeHow was this verified?
Raw
node --experimental-strip-types --test pipeline/*.test.mjs: 2774 tests, 2774 pass, 0 fail. Reverting either half (SENTRY_SCOPEtofull, orVITE_SENTRY_SCOPEtofull) turns its pin test red; both were restored.pnpm --filter @handsontable/demo-api typecheckexits 0.This is a config flip: the effect is observable only after deploy, as Sentry volume dropping to uncaught errors while Grafana still shows the handled diagnostics (the watch steps in DEV-3099).
Checklist
runner/config/frameworks.json(see CONTRIBUTING.md); otherwise it won't appear on demos.handsontable.compnpm build(andpnpm dev) in the affected example/server-example locallyNot applicable: no example is added or renamed.
Related issue(s):