Repository navigation
Write an HTML report with a Mol* view (--no-report to turn it off) - #49
Merged
Merged
Conversation
--report writes report.html and state.mvsj (MolViewSpec, as in PowerFit) in the output directory: the accessible complexes, violations, z-scores with the restraint labels, the interaction tables with -is, and a Mol* view of the fixed chain with the accessible interaction space for each number of consistent restraints, plus the occupancy grids with -oa. Files are referred to by relative names. The report is built from the output files, which do not change. The test cases run with --report, and each reference directory has its report. Closes #46 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- With -is, the report colors the selected residues of the fixed chain from white to red by their average number of interactions per complex; occupancy maps are green. The view is centered on the fixed chain instead of the whole map grid. - disvis.log starts with a header giving the DisVis version. - New reference run PRE5-PUP2 cpu/coarse-is-oa (-is -oa --report), with occupancy grids and interaction tables; its other output files are identical to cpu/coarse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- report.html is written by default; --no-report turns it off. - With -is, the report lists the 10 most contacted receptor and ligand residues for each N. - The tables sort by a column on a click on its header. - tests/test_report.py closes disvis.log, which Windows cannot remove while it is open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Read the interaction files once, with helpers.parse_interactions. - Skip comments in the restraints file as parse_restraints does. - main() closes disvis.log before writing the footer; the test no longer needs logging.shutdown(). - The molviewspec warning filter moves from report.py to the test: the warning only shows with -W error. - No color nodes for residues without interactions (white is the base). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sverhoeven
requested changes
Nov 4, 2026
Contributor
There was a problem hiding this comment.
Works for me.
I was able to generate the report and use --no-report
Regarding inline comments.
There are 3 requests for changes: README.md, slow test and http server log.
The other comments are suggestions.
Btw congrats on https://pypi.org/project/disvis/
- README: no single options listed (--help does). - The http.server hint is also printed to the terminal. - The accessible complexes table starts with the most restraints, as the snapshots. - Mol* 5.13.1. - The sorted column shows ▲ or ▼. - The ligand, restraints and selection files are copied to the output directory and linked for download. - The test calls generate_report on stored text output (tests/data/output), without mocking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
Report: sort arrows, how-to-view hint in the terminal, link the input structure
haddocking/whiscy#65
Closed
amjjbonvin
added a commit
to haddocking/whiscy
that referenced
this pull request
Nov 6, 2026
… structure (#72) * Report: sort arrows, how-to-view hint in the terminal, link the input structure From the review of the DisVis report (haddocking/disvis#49): - show ▲/▼ on the sorted column of the residue table (Rank ▲ on load); - end whiscy_haddock with how to view report.html (python -m http.server), in the terminal and whiscy.log, with the relative path; - link the input structure in the report, copied next to it when it is not in the current directory (a different file of the same name is kept). Closes #65 * Prepare the v1.6.1 release (CHANGELOG, version) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- README.md: a "Viewing the report" section (python -m http.server), and the disvis.log header and footer. - CHANGELOG.md: the disvis.log header and footer. - Regenerated disvis.log of all reference runs, with the version header and the report footer (CPU on the Apple M2 Pro, GPU on the RTX 6000 Ada); the other output files are byte-identical. - test-cases/README.md: run times of these runs for the M2 Pro -p 8 and RTX 6000 Ada rows, and the notes that depend on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Adds an HTML report, so the CSB portal can show DisVis results with a Mol* view, as it does for PowerFit, and drop the Chimera images (#46).
DisVis now writes
report.htmlandstate.mvsj(MolViewSpec, Mol* 5.13.1 mvs-stories from jsDelivr, as inpowerfit_em/report.py) in the output directory, and copies the input files there (the report shows the fixed chain and links all of them);--no-reportturns this off.disvis.logand the terminal end with how to view the report. The report shows what the portal's results page shows now:A27(CA)-A18(CA)), z ≥ 1 highlighted;-is, for each N the 10 most contacted receptor and ligand residues (most first), and the full interaction tables, colored from white to green (most contacted);accessible_interaction_space.mrcfor each N and, with-oa,occupancy_N.mrc(green); with-is, the selected residues of the fixed chain are colored from white to red by their average number of interactions per complex.The tables (except the lists of most contacted residues) sort by a column when its header is clicked (▲/▼ on the sorted column). All files are referred to by relative names. The report is built from the output files, which are unchanged. New dependency:
molviewspec.disvis.lognow starts with a header giving the DisVis version.Each
example-resultsdirectory has its report (generated from the existing reference files). New reference runPRE5-PUP2-complex/example-results/cpu/coarse-is-oa(-is selection.res -oa), to show the occupancy maps and interaction analysis; its other output files are identical tocpu/coarse.How was this tested?
tests/test_report.py):generate_reporton the text output of a small-is -oarun (tests/data/output); checks one snapshot per N, relative URLs only, the restraint labels and interaction tables. All 27 unit tests pass (-W error), also in the Pyodide wheel (local cibuildwheel).test-cases/check_test_cases.py(coarse, now with the report): output files byte-identical to the references.coarse-is-oa, RNA polymerase II fine). The residue colors are not checked by the unit test.Not tested: the portal embedding. Opened from disk (
file://), the browser blocks the files of the viewer; the page then says to serve the directory withpython -m http.server.AI assistance
Written with Claude Code; checked as above.
Checklist
README.md,INSTALLATION.md)test-cases/*/example-results/updated if the output changes (output unchanged; reports and thecoarse-is-oarun added)Related issues
Closes #46
Notes for reviewers
accessible_interaction_space_<N>.mrc; DisVis writes a single map whose value is the number of consistent restraints, so the report shows it at level N − 0.5 for each N (Chimera in the portal uses level N).-W error).🤖 Generated with Claude Code