[joshuaguardian]

What does this change?

Update the portrait immersive layout to match designs

Why?

How has this change been tested?

Storybook and manually

Screenshots

[github-actions]

Deploy build 33152 of dotcom:rendering-all to CODE

All deployment options

• Deploy build 33152 of dotcom:rendering-all to CODE
• Deploy parts of build 33152 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[frederickobrien]

Looks good to me, though would value @JamieB-gu's two cents on the changes made to grid.ts as that powers a lot of layout stuff these days

[joshuaguardian]

Looks good to me, though would value @JamieB-gu's two cents on the changes made to grid.ts as that powers a lot of layout stuff these days

ah I was going to remove that actually as it just fixed this horizontal scrolling in storybook, I need to do some more testing...

[joshuaguardian]

Showing the horizontal scrollbar without the grid.ts changes

Large width 965px

Medium width 725px

[joshuaguardian]

with the grid.ts changes:

larger size 965px

Medium size 725px

[github-actions]

🚀 Image pushed to AWS ECR

Image digest: sha256:6ec0b626f3de06f999cb00c97a0bf3b665e2f364366bead3544adcd114278768

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:6ec0b626f3de06f999cb00c97a0bf3b665e2f364366bead3544adcd114278768"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-fix-portrait-view"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-33152"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

---

From guardian/actions-ecr.

[frederickobrien]

If I understand right @joshuaguardian does the @guardian/commercial-dev approved max-width: 100%; for ads make the changes to grid.ts unnecessary now?

[joshuaguardian]

No the grid changes are still necessary - essentially I'm saying the gap between columns can be smaller when there isn't as much room on the screen - we see horizontal scrolling at various breakpoint sizes, this removes that. The ad slot change is also part of removing the horizontal scroll at smaller screen sizes

[frederickobrien]

No the grid changes are still necessary - essentially I'm saying the gap between columns can be smaller when there isn't as much room on the screen - we see horizontal scrolling at various breakpoint sizes, this removes that. The ad slot change is also part of removing the horizontal scroll at smaller screen sizes

Roger that - good stuff!

[github-actions]

Deploy build 3974 of dotcom:ab-testing to CODE

All deployment options

• Deploy build 3974 of dotcom:ab-testing to CODE
• Deploy parts of build 3974 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.