Repository navigation
Conversation
All aspect ratio quick settings options previously shared the same generic aspect_ratio icon. Replace it with Material Symbols icons that reflect each ratio: crop_portrait (3:4), crop_square (1:1), and crop_9_16 (9:16). Remove the now-unused ic_aspect_ratio drawable.
Match the order used in the quick settings design.
Keep the settings dialog consistent with the quick settings order.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes the camera aspect ratio settings and quick settings UI to follow a consistent order (3:4, 1:1, 9:16) and introduces distinct crop icons for each ratio. It also adds unit and device tests to verify the new ordering and selection behavior. The review feedback suggests correcting the path data in ic_crop_9_16.xml to represent a mathematically accurate 9:16 aspect ratio, and reordering the enum constants in CameraAspectRatio to match the updated UI sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ic_aspect_ratiodrawable with distinct Material Symbols vector drawables for each aspect ratio in quick settings:3:4->ic_crop_portrait1:1->ic_crop_square9:16->ic_crop_9_16ic_aspect_ratiodrawable resource.AspectRatioUiStateAdapter) and the Settings dialog (AspectRatioSetting) to3:4,1:1,9:16to match the design.Testing
./gradlew :ui:uistateadapter:capture:testDebugUnitTest :ui:components:capture:testDebugUnitTest :feature:settings:testDebugUnitTest