Repository navigation
In ThreadFactoryBuilder, propagate null from newThread on the backing ThreadFactory. - #8752
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1001012598
branch
from
October 18, 2026 17:21
93f020d to
70b685b
Compare
…acking `ThreadFactory`. `ThreadFactory.newThread` is permitted to return `null` to reject a request to create a thread. Previously, a factory built by `ThreadFactoryBuilder` threw `NullPointerException` if its backing factory returned `null`. Fixes #3568. Closes #8742. RELNOTES=In the `ThreadFactory` returned by `ThreadFactoryBuilder`, a null return from `newThread` on the backing `ThreadFactory` is now propagated to the caller. Previously it triggered a NullPointerException. PiperOrigin-RevId: 1001877586
copybara-service
Bot
force-pushed
the
test_1001012598
branch
from
October 18, 2026 17:41
70b685b to
669a232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ThreadFactoryBuilder, propagatenullfromnewThreadon the backingThreadFactory.ThreadFactory.newThreadis permitted to returnnullto reject a request to create a thread. Previously, a factory built byThreadFactoryBuilderthrewNullPointerExceptionif its backing factory returnednull.Fixes #3568.
Closes #8742.
RELNOTES=In the
ThreadFactoryreturned byThreadFactoryBuilder, a null return fromnewThreadon the backingThreadFactoryis now propagated to the caller. Previously it triggered a NullPointerException.