Repository navigation
Conversation
The Versioned/Unversioned blocks documented the pre-modules GOPATH workflow (go get -u -d, cd $GOPATH/src, git checkout, go build -o). That path is broken on Go 1.16+, and `go get` stopped installing command binaries in Go 1.18 — which is the failure reported in golang-migrate#603. Replace both blocks with the working `go install <pkg>@<version>` form (pinned, latest, and multi-driver), note where the binary is placed, and drop the now -orphaned Go 1.15 GOPATH notes. Verified with Go 1.26. Fixes golang-migrate#603
Author
|
Hi maintainers, the only failing check on this PR is the Go 1.25.x test job. The failures are Docker containers timing out on startup ( |
|
coverage: 54.938%. first build — shaikn6:docs/modernize-cli-go-toolchain-install into golang-migrate:master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The With Go toolchain section of
cmd/migrate/README.mddocumented the pre-modules GOPATH workflow under Versioned / Unversioned:That path no longer works:
go getstopped installing command binaries in Go 1.18 (go getis now for dependency management only).go get ... github.com/golang-migrate/migrate/cmd/migratepath resolves to the pre-/v4module and fails withfound (v3.5.4+incompatible), but does not contain package …— this is exactly the failure in CLI Install instructions are incorrect for Go 1.16+ #603.$GOPATH/srcisn't populated in module mode.Change
Replace the two blocks with the working
go install <pkg>@<version>form — pinned release,@latest, and a multi-driver example — plus a note on where the binary is installed. Drop the two now-orphaned "Go 1.15 and below" notes.Docs-only; no code touched.
Verified
Fixes #603