Repository navigation
fix: clearer error when the migrations source has no files - #1405
Open
AlisinaDevelo wants to merge 3 commits into
Open
AlisinaDevelo wants to merge 3 commits into
AlisinaDevelo wants to merge 3 commits into
Conversation
This was referenced Jun 29, 2026
Author
|
Checking in on the no-migration-files error. It returns a typed error while preserving os.ErrNotExist wrapping, and the Go 1.24 and 1.25 tests and lint checks are green. If there’s a compatibility concern or a preferred error shape, I’m happy to adjust; otherwise I’d appreciate a review. |
Author
|
Hey, just checking in on this one—does the error-shape change need anything else from me before review? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1314.
An empty or mistyped migrations directory currently fails with
first .: file does not exist, which gives no hint about the real cause. This returns a newErrNoMigrationFilesinstead. It still wrapsos.ErrNotExist, so existingerrors.Ischecks keep working.The same cryptic error came up via
Up()andMigrate()/Steps()since they share the code path, so both are covered. Added a test.