Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a typed nil
*py.ModuletoRunCodecurrently dereferencesmod.Globalsand panics. This affects callers that carry a module pointer through a loop and initialize it on the firstRunFile/RunSrccall, as reported by @SolarLune in #249.Treat a nil module pointer like an untyped nil: create and return a new module. Non-nil module pointers still execute against the existing globals. Document the typed-nil behavior and exercise
RunCode,RunSrc, andRunFile, followed by reuse of the returned module.Fixes #249.
Validation on Linux/arm64:
go run ./ci/run-tests.go -tags=ci -race -coverpkg=github.com/go-python/gpython/...passes.goimportsandgit diff --checkpass. Standalone Go 1.27.1go vet ./...reports the same 182 existing diagnostics on unchanged main (unkeyed literals and unreachable code); no new diagnostics.Required author registration: go-python/license#24.
AI assistance: implementation and tests were developed and verified with an AI coding agent.