Repository navigation
Conversation
Fingerprint rules were a plain textarea, so a typo'd matcher, a missing space before ->, or an arrow pasted from somewhere else only showed up as a generic syntax error after saving. The editor now highlights each part of a rule and underlines mistakes once typing pauses. Hovering an underline explains it, and a collapsed summary under the field counts the errors and warnings. The tokenizer follows the backend grammar, so errors line up with what the backend rejects on save. The example rules above the field are highlighted too. Assumes #128461 lands first, which saves a → as ->. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 12 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fingerprint rules were a plain textarea, so a typo'd matcher, a missing space before
->, or an arrow from another language only showed up as a generic syntax error after hitting save.The editor now highlights each part of a rule and underlines mistakes once typing pauses. Hovering an underline explains it, and a collapsed summary under the field counts the errors and warnings. Warnings are for rules that save but probably don't do what was meant, like an unknown
{{ variable }}, an unquotedtitle=, or a trailing# commentthat ends up in the fingerprint.The tokenizer follows the backend grammar in
parser.py. I fuzzed it against the backend with a couple hundred thousand random configs and it never flags one the backend accepts.Depends on #128461, which saves a
→as->, so the editor treats a→as an arrow.