Repository navigation
ref(preprod): Build size analysis detector on DetectorHandler evaluation - #127134
Draft
saponifi3d wants to merge 1 commit into
Draft
saponifi3d wants to merge 1 commit into
saponifi3d wants to merge 1 commit into
Conversation
saponifi3d
added this pull request to stack #127136
October 10, 2026 01:03
Contributor
Sentry Snapshot Testing
|
PreprodSizeAnalysisDetectorHandler drops its copy of the condition evaluation and occurrence building. It filters packets in extract_value, and overrides get_issue_fingerprint and get_occurrence_id to keep one issue per regression; DetectorHandler and the platform do the rest.
saponifi3d
force-pushed
the
jcallender/detector-handler-3-preprod
branch
from
October 21, 2026 23:50
be2125f to
e9ab7f7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreprodSizeAnalysisDetectorHandlernow usesDetectorHandler's default evaluation instead of its own copy of the condition evaluation and occurrence building (−84 lines). What's left is product logic: the query filter inextract_value(an emptyDetectorGroupValuesskips evaluation), the occurrence content increate_occurrence, and two hooks to keep one issue per regression (get_issue_fingerprintreturns a fresh fingerprint, andget_occurrence_idreuses the event id).This is the only PR in the stack that changes a payload. Preprod occurrences now get the same platform evidence and event data as every other detector. Across the preprod suites (31 tests, 23 evaluations), these are the only differences:
evidence_data.data_packet_source_idpreprod-size-analysis:<project_id>evidence_data.data_sources[](preprod detectors have no data source)event_data.environmentNoneevent_data.timestampcreate_occurrenceoccurrence.detection_time(datetime)Titles, subtitles, evidence display, tags, fingerprints, conditions, and priorities are unchanged.
Preprod owners, please review: since preprod detectors have no
DataSource, building evidence logs a "Matching data source not found" warning for each preprod occurrence. If that warning is unwanted, we can skip the data source lookup when the detector type doesn't require a data source.