Skip to content

ref(preprod): Build size analysis detector on DetectorHandler evaluation - #127134

Draft
saponifi3d wants to merge 1 commit into
jcallender/detector-handler-2-lifecyclefrom
jcallender/detector-handler-3-preprod
Draft

saponifi3d wants to merge 1 commit into
jcallender/detector-handler-2-lifecyclefrom
jcallender/detector-handler-3-preprod

Conversation

@saponifi3d

@saponifi3d saponifi3d commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

PreprodSizeAnalysisDetectorHandler now uses DetectorHandler's default evaluation instead of its own copy of the condition evaluation and occurrence building (−84 lines). What's left is product logic: the query filter in extract_value (an empty DetectorGroupValues skips evaluation), the occurrence content in create_occurrence, and two hooks to keep one issue per regression (get_issue_fingerprint returns a fresh fingerprint, and get_occurrence_id reuses the event id).

This is the only PR in the stack that changes a payload. Preprod occurrences now get the same platform evidence and event data as every other detector. Across the preprod suites (31 tests, 23 evaluations), these are the only differences:

Field Before After
evidence_data.data_packet_source_id absent packet source id, e.g. preprod-size-analysis:<project_id>
evidence_data.data_sources absent [] (preprod detectors have no data source)
event_data.environment absent None
event_data.timestamp epoch float from create_occurrence occurrence.detection_time (datetime)

Titles, subtitles, evidence display, tags, fingerprints, conditions, and priorities are unchanged.

Preprod owners, please review: since preprod detectors have no DataSource, building evidence logs a "Matching data source not found" warning for each preprod occurrence. If that warning is unwanted, we can skip the data source lookup when the detector type doesn't require a data source.

@saponifi3d
saponifi3d added this pull request to stack #127136 October 10, 2026 01:03
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 10, 2026
@sentry

sentry Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 760 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

PreprodSizeAnalysisDetectorHandler drops its copy of the condition evaluation and occurrence building. It filters packets in extract_value, and overrides get_issue_fingerprint and get_occurrence_id to keep one issue per regression; DetectorHandler and the platform do the rest.
@saponifi3d
saponifi3d force-pushed the jcallender/detector-handler-3-preprod branch from be2125f to e9ab7f7 Compare October 21, 2026 23:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant