Repository navigation
fix(integrations): Keep shared external issues in the old org on project transfer #126319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaind
wants to merge
4
commits into
master
Choose a base branch
from
ivan/scope-external-issue-group-lookup-review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−9
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed430c0
fix(integrations): Keep shared external issues in the old org on proj…
vaind 852b488
Merge remote-tracking branch 'origin/master' into ivan/scope-external…
vaind d52b527
fix(integrations): Skip external issue transfer when the org is uncha…
vaind 64cfec4
Merge remote-tracking branch 'origin/master' into ivan/scope-external…
vaind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy breaks Jira panel lookup
Medium Severity
Copying a shared
ExternalIssueinto the destination org leaves two rows with the sameintegration_idandkey. The Jira issue panel loads that row with.get(integration_id, key), catchesMultipleObjectsReturned, and treats the ticket as unlinked, so groups from both orgs disappear from the panel after transfer.Reviewed by Cursor Bugbot for commit 64cfec4. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might still be an issue, though it looks like the DB constraint is on
org_id + integration_id + keyso if possible, getting a specific org to query would resolve this. IIRC though, there is no indicator on those jira webhooks as to which organization should be loaded, and i think we do something in the control silo to fanout (so maybe this isn't an issue)?Worth confirming that no call sites will hit the multipleobjectsreturned issue tho