Repository navigation
fix: MCP integration records tool calls that return isError as successful - #7942
Open
Roshan931 wants to merge 1 commit into
Conversation
Signed-off-by: Robert Markovski <5818108+Roshan931@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7890
Root cause
MCP v2 middleware ignores
isErrorin tool resultsChanges
_instrument_v2_tool_call, mark thetools/callspan as failed when the handler result dict carriesisError, usingSpanStatus.ERRORfor streamed spans andSPANSTATUS.INTERNAL_ERRORotherwise (same pattern as the openai_agents execute_tool span). Added a v2-only regression test covering both streamed and static span lifecycles.