Repository navigation
Conversation
1 of 3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5668 +/- ##
==========================================
- Coverage 76.13% 76.12% -0.02%
==========================================
Files 528 530 +2
Lines 19579 19615 +36
Branches 3829 3839 +10
==========================================
+ Hits 14906 14931 +25
- Misses 3791 3799 +8
- Partials 882 885 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wedamija
force-pushed
the
danf/quartz-crons
branch
from
October 6, 2026 02:03
6128fc0 to
91bd0d1
Compare
… dependencies and streamlining SentryCronJobListener options handling
…and update Quartz integration
… collection parameter and streamlining option configuration
…dSentryScope method, update SentryMetricsMiddleware to support configurable options
…ibute rename Co-Authored-By: Claude <noreply@anthropic.com>
The AddSentry() remarks still said job exceptions are left to the logging integration. The scope middleware has captured them again since 73e5551. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…schedules Reads every monitored trigger, cached for a minute, like Sentry.Hangfire. Replaces the check for jobs with several triggers.
A job without an identity has fallen back to its class name with a debug message, not a warning, since fe97276. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Heads-up: #5505 now detects shared slugs differently (787ab1e), and this PR will stop compiling once it merges that in. Both packages compile the same
|
Picks up #5757, which fixes the Blazor WASM E2E job on Ubuntu 26.04 runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ports the shared slug check to Quartz 3: QuartzApi.GetTriggersAsync reads each job and the triggers of each monitored one, since Quartz 3 has no bulk lookups. The test shim gets the new ReturnsTriggers and LookedUpTriggers, and HasSeveralTriggersAsync is gone. Co-Authored-By: Claude <noreply@anthropic.com>
…gers A job left in a persistent store after its class was renamed or deleted made the whole trigger read throw, so no monitored job sent its schedule. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…aptured Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Quartz 3 annotates GetJobDetail differently across target frameworks. Co-Authored-By: Claude <noreply@anthropic.com>
…tion on Quartz's ErrorLogger logs the exception again, wrapped in a JobExecutionProcessException that the default DeduplicateMode doesn't unwrap. AddSentry now adds a log entry filter for that entry, to whichever SentryLoggingOptions the app uses (SentryAspNetCoreOptions included), when the middleware captured the inner exception. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
…log filter setup Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Adds
Sentry.Quartz3, the Quartz.NET 3.x version ofSentry.Quartz. Quartz 4 only targets net10.0, so apps on .NET Framework or older .NET stay on Quartz 3. It builds the shared core files against Quartz[3.6.0,4.0.0)for net8.0 to net10.0 and net462, and runs them from anIJobListenerbecause Quartz 3 has no job middleware.As in
Sentry.Quartz, jobs with[SentryMonitorSlug]send check-ins with their trigger's schedule unlessSendMonitorConfigis off. A listener can't wrap the job, so there is no per-job scope or exception capture. Under Quartz 4 the listener would never be called, so it logs an error pointing toSentry.Quartz.A release-registry entry is needed before the first release.
Stacked on #5505 by @michaelmairegger, which is still open. The base branch
danf/quartz-5505-rebasedis a copy of its branch.Docs: getsentry/sentry-docs#19790