Repository navigation
ci: publish docker images for main and releases only - #1759
Merged
Merged
Conversation
- Stop publishing PR_<n> images for every same-repo PR. PR images are now on demand via publish-pr-multiarch.yml, which builds the PR head (fork PRs included) instead of the ref it was dispatched from, and reads but never writes the build cache. - Stop publishing SHA_<sha> images; nothing deploys them. - Run publishes for the same ref one at a time so an older main build can't move the main tag back. - Least-privilege token (contents: read) and no persisted git credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@kevinpapst Apologies for the claude-noise, but does the gist of this change make sense to you - I'm streamlining the process so we don't keep creating and pushing tags for all PRs |
kevinpapst
approved these changes
Nov 4, 2026
Contributor
There was a problem hiding this comment.
Good cleanup. I wasn't sure if you need the tags, that's why I left them out in my PRs.
The permissions: read is wildly recommended for security.
And the removal of all the (likely) unused docker tags makes the hub page much more user friendly.
One tiny feedback, unrelated to the actual change.
LGTM 👍
toJSON(github) includes the job token; it is masked in logs, but nothing needs the dump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1755, #1756 and #1757.
Docker Hub has 532 tags for
getfider/fider. 93 of the latest 100 arePR_*orSHA_*images that nothing deploys. Hosted deploysmain, and self-hosters usestableorvX.Y.Z.publish.ymlmainand published releases publish images. AutomaticPR_<n>images are gone.SHA_<sha>images are no longer published.mainis the only branch tag.mainrun one at a time, so an older build that finishes last can no longer movemain, which hosted deploys, back to older code. Each release has its own group, so releases never wait on each other.permissions: contents: read. The repo default token iswrite, and this job builds code while holding the Docker Hub secrets. Docker: protect stable tag #1757'sreleases/latestcall only needs read access.persist-credentials: falseon checkout.publish-pr-multiarch.yml(on-demand PR images, e.g. for test instances)main) and only usedpr_numberfor the tag name. It now checks outrefs/pull/<n>/head, so fork PRs work too.COMMITHASHis now the PR head commit.pr_numberinput istype: number.mainand release builds reuse.permissions: contents: read,persist-credentials: false.Not tested.
workflow_runworkflows always run frommain's copy, so this PR's CI doesn't exercise them. After merge, check:mainupdatesgetfider/fider:main;PR_<n>with that PR's code.After merge (manual): delete the old
PR_*andSHA_*tags on Docker Hub if wanted.🤖 Generated with Claude Code